Skip to content

feat: Adopt the flagsmith entrypoint#7901

Draft
khvn26 wants to merge 1 commit into
mainfrom
feat/adopt-flagsmith-entrypoint
Draft

feat: Adopt the flagsmith entrypoint#7901
khvn26 wants to merge 1 commit into
mainfrom
feat/adopt-flagsmith-entrypoint

Conversation

@khvn26

@khvn26 khvn26 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7891.

Adopts the flagsmith CLI entrypoint (from flagsmith-common) for container startup, replacing the bespoke sequencing in api/scripts/run-docker.sh.

  • run-docker.sh is reduced to a backwards-compatible shim (exec flagsmith "$@"), so anything invoking the script path or its verbs keeps working.
  • The image ENTRYPOINT is now flagsmith; APPLICATION_LOGGERS (previously defaulted in the shell script) moves to a Dockerfile ENV so logging is unchanged.
  • The startup verbs are driven by settings, set in app/settings/common.py from the databases actually configured.
  • The task processor in SaaS no longer migrates on every task start. Its task definition command becomes start task-processor.
  • The temporary startPeriod raised to 120s in fix(infra): Task processor tasks killed during startup by health check #7887 is lowered to 30s in both the prod and staging task-processor definitions, which comfortably covers the new single-boot startup.

How did you test this code?

End-to-end against a local environment, exercising each verb via the flagsmith entrypoint:

  • flagsmith migrate — waits for the DB, migrates the configured databases, creates the cache table.
  • flagsmith serve — waits for the DB, starts the API; /health/liveness served on :8000.
  • flagsmith start task-processor — the new task-definition command; binds :8000 and starts the worker threads.
  • flagsmith migrate-and-serve — runs migrate, then bootstrap (via FLAGSMITH_STARTUP_COMMANDS), then serves.

@khvn26
feat(api): Adopt the flagsmith entrypoint for container startup
e34f516 
Replace the bespoke startup sequencing in run-docker.sh with the composite
verbs provided by the flagsmith-common `flagsmith` entrypoint:

- run-docker.sh becomes a thin `exec flagsmith "$@"` shim, kept for callers
  that reference the script path or its verbs directly.
- The image ENTRYPOINT is now `flagsmith`; the APPLICATION_LOGGERS default the
  shell script used to set moves to a Dockerfile ENV.
- Startup verbs are driven by new settings built from the configured databases
  (FLAGSMITH_MIGRATE_DATABASES, FLAGSMITH_WAIT_FOR_MIGRATIONS_DATABASES,
  FLAGSMITH_STARTUP_COMMANDS).
- The task processor task definition starts via `start task-processor` and no
  longer migrates on every task; migrations run once per deploy via the
  migration task. startPeriod drops from 120s to 30s for the faster boot.

flagsmith-common is temporarily sourced from its branch until the verbs are
released; revert to the PyPI release before merge (see pyproject TODO).

beep boop
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 29, 2026 3:30am
flagsmith-frontend-preview Ignored Ignored Jun 29, 2026 3:30am
flagsmith-frontend-staging Ignored Ignored Jun 29, 2026 3:30am

Request Review

@github-actions github-actions Bot added api Issue related to the REST API infrastructure feature New feature or request and removed infrastructure labels Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (c153c3f) to head (e34f516).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7901   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files        1487     1487           
  Lines       58493    58493           
=======================================
  Hits        57687    57687           
  Misses        806      806

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 marked this pull request as ready for review June 29, 2026 10:44
@khvn26 khvn26 requested review from a team as code owners June 29, 2026 10:44
@khvn26 khvn26 requested review from emyller and germangarces and removed request for a team June 29, 2026 10:44
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7901 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7901 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7901 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7901 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7901 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7901 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.4 seconds
commit  e34f516
info  🔄 Run: #17918 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.3 seconds
commit  e34f516
info  🔄 Run: #17918 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  2 failed
passed  1 passed

Details

stats  3 tests across 3 suites
duration  25.5 seconds
commit  e34f516
info  📦 Artifacts: View test results and HTML report
🔄 Run: #17918 (attempt 1)

Failed tests

firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

17 screenshots compared. See report for details.
View full report

germangarces
germangarces approved these changes Jun 29, 2026
View reviewed changes

@germangarces germangarces left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26 khvn26 marked this pull request as draft June 29, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germangarces germangarces germangarces approved these changes
@emyller emyller Awaiting requested review from emyller emyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

@emyller emyller

@germangarces germangarces

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proxy run-docker.sh to flagsmith entrypoint

3 participants

@khvn26 @germangarces @emyller